fix: handle NPE when NotifyCenter.INSTANCE is null during graceful shutdown#4284
Open
Senrian wants to merge 1 commit intoalibaba:2025.1.xfrom
Open
fix: handle NPE when NotifyCenter.INSTANCE is null during graceful shutdown#4284Senrian wants to merge 1 commit intoalibaba:2025.1.xfrom
Senrian wants to merge 1 commit intoalibaba:2025.1.xfrom
Conversation
…utdown When Spring context closes, if Nacos client shutdown hooks have already destroyed NotifyCenter.INSTANCE, autoServiceRegistration.stop() throws NPE. Catch NPE explicitly and log a warning instead of propagating. Fixes alibaba#4283
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When Spring context closes,
NacosGracefulShutdownDelegate.doGracefulShutdown()callsautoServiceRegistration.stop()which internally deregisters subscribers from NacosNotifyCenter. However, if the Nacos client shutdown hooks have already destroyedNotifyCenter.INSTANCE, this results in:Fix
Add explicit
NullPointerExceptioncatch indoGracefulShutdown()and log a warning instead of propagating, since this NPE is safe to ignore during shutdown when the NotifyCenter has already been cleaned up.Testing
The existing test
sameContextShouldTriggerStopand other tests inNacosGracefulShutdownDelegateTestscontinue to pass since they mockautoServiceRegistration.stop()to not throw NPE.Fixes #4283